-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hacks to avoid previous aesara gammainc(c) limitations #4467
Labels
Comments
ricardoV94
changed the title
Remove
Remove hacks to workaround aesara gammainc(c) limitations
Feb 9, 2021
ricardoV94
changed the title
Remove hacks to workaround aesara gammainc(c) limitations
Remove hacks to avoid previous aesara gammainc(c) limitations
Feb 9, 2021
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jun 4, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jun 4, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jun 4, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jun 10, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jul 12, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jul 12, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jul 12, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jul 13, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jul 13, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jul 13, 2021
…nverseGamma` Closes pymc-devs#4467
ricardoV94
added a commit
to ricardoV94/pymc
that referenced
this issue
Jul 15, 2021
…nverseGamma` Closes pymc-devs#4467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a reminder issue
The gamma functions in aesara were changed to work with invalid values (returning nan) instead of doing a c-level assertion (pymc-devs/pytensor#290). The following lines can be changed / removed once pymc3 is paired with the next version of aesara:
Distributions:
https://github.com/pymc-devs/pymc3/blob/89916ad724ae88ebb4c1af3d65919b87b318f180/pymc3/distributions/continuous.py#L2631-L2634
https://github.com/pymc-devs/pymc3/blob/89916ad724ae88ebb4c1af3d65919b87b318f180/pymc3/distributions/continuous.py#L2805-L2808
Unittests:
https://github.com/pymc-devs/pymc3/blob/e40304b98503907f620d67d4a9ff6e42c63171d1/pymc3/tests/test_distributions.py#L1231-L1240
https://github.com/pymc-devs/pymc3/blob/e40304b98503907f620d67d4a9ff6e42c63171d1/pymc3/tests/test_distributions.py#L1253-L1262
The text was updated successfully, but these errors were encountered: