Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: progress bar display #420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: progress bar display #420

wants to merge 2 commits into from
+22 −6

Conversation

aphc14
Copy link
Contributor

@aphc14 aphc14 commented Jan 29, 2025

Issue

  • Progress bar percentage is not refreshed after the pathfinder finishes, leaving the completion percentage less than 100%

Changes

  • Progress bar percentage is refreshed after completion to display progress of 100%
  • Add progress bar details of the number of paths complete. Users can opt to stop progress knowing the number of paths completed rather than as a percentage.

aphc14 added 2 commits January 29, 2025 20:56
@aphc14
fix: progress bar display
e6fbb11 
- Progress bar percentage is refreshed after completion to display progress of 100%
- Add progress bar details of the number of paths complete
@aphc14
edit PathStatus.ELBO_ARGMAX_AT_ZERO message for clearer explanation
93257fc
@aphc14
Copy link
Contributor Author

aphc14 commented Jan 31, 2025

I think parts of the pymc-extras/.github/workflows/pypi.yml needs to be changed: from actions/download-artifact@v3 to actions/download-artifact@v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aphc14