docstrings update in model_builder.py #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
reviewed
Apr 20, 2023
|
Conflict, but LGTM otherwise. |
…pymc-devs#140) * Return posterior predictive samples from all chains This fixes a bug where only values from one chain were returned. It also refactors the prediction logic to reduce duplication, and makes the output of predict_posterior() consistent in type and shape with the output of pymc.sample_posterior_predictive(). * keep attributes even when computing posterior means * Add/test combined arg, revert method order * Fix import order. --------- Co-authored-by: Max Joseph <[email protected]> Co-authored-by: Thomas Wiecki <[email protected]>
twiecki
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the docstrings in model_builder.py , ensures that they follow the numpydoc conventions