Add build_model abstractmethod to ModelBuilder
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
build_model abstractmethod to ModelBuilder
ricardoV94
previously approved these changes
Apr 19, 2023
twiecki
reviewed
Apr 19, 2023
pymc_experimental/model_builder.py
Outdated
| >>> 'obs_error': 2, | ||
| >>> } | ||
| >>> 'a' : { | ||
| >>> 'a_loc': 7, |
There was a problem hiding this comment.
Should this not just be loc, the a seems redundant.
There was a problem hiding this comment.
true, good catch
twiecki
reviewed
Apr 19, 2023
pymc_experimental/model_builder.py
Outdated
| @@ -191,7 +220,7 @@ def load(cls, fname: str): | |||
| data=idata.fit_data.to_dataframe(), | |||
| ) | |||
| model_builder.idata = idata | |||
| model_builder.build() | |||
| model_builder.idata = model_builder.fit() | |||
There was a problem hiding this comment.
What if the model was already fit?
twiecki
approved these changes
Apr 19, 2023
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to ModelBuilder that are required for full integration with MMM, the final shape is still open for discussion.
main changes:
-build_model moved out of constructor of baseMMM and called in fit() in model_builder
-abstract definition of build_model added to model_builder
-abstract definition of _serialisable_model_config added to model_builder (solves the unserialisability of time series
-save now requires model to be fit first
-added test checking that RuntimeError is raised if save is called before fit
-model is not build at initialisation of MMM, but with first fit, reason is that chain calling constructors was causing issues with object creation timing resulting in not reliable inheritance