Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add r2m2d2cp prior #137

Merged
merged 16 commits into from
May 25, 2023
Merged

Add r2m2d2cp prior #137

merged 16 commits into from
May 25, 2023

Conversation

ferrine
Copy link
Member

@ferrine ferrine commented Apr 7, 2023

I think I'll need to add tests and some examples

@ricardoV94 ricardoV94 changed the title add r2m2d2cp Add r2m2d2cp Apr 12, 2023
@ricardoV94 ricardoV94 added the enhancements New feature or request label Apr 12, 2023
@ferrine
Copy link
Member Author

ferrine commented Apr 19, 2023

How would a hierarchical API look like?

ricardoV94
ricardoV94 reviewed May 18, 2023
View reviewed changes
docs/api_reference.rst Outdated Show resolved Hide resolved
@ricardoV94
Copy link
Member

Looks good, just a question about one entry you added to the docs.

We should follow up with a PyMC examples showing this in practice, WDYT?

@ferrine
Copy link
Member Author

ferrine commented May 21, 2023

Lets create an issue and I'll make that happen

@ferrine
Copy link
Member Author

ferrine commented May 22, 2023

I've reverted my changes in documentation to quite minimal, there are still issues left, but I guess they should be addressed in separate PRs

@ferrine
Copy link
Member Author

ferrine commented May 24, 2023

This is ready to review

@ferrine ferrine requested a review from ricardoV94 May 24, 2023 15:40
ricardoV94
ricardoV94 previously approved these changes May 25, 2023
View reviewed changes
@ricardoV94 ricardoV94 changed the title Add r2m2d2cp Add r2m2d2cp prior May 25, 2023
@ferrine ferrine merged commit b3f6581 into main May 25, 2023
@ferrine ferrine deleted the R2D2M2CP branch May 25, 2023 11:36
@twiecki
Copy link
Member

twiecki commented May 25, 2023

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki left review comments

@ColCarroll ColCarroll ColCarroll left review comments

@ricardoV94 ricardoV94 ricardoV94 approved these changes

Assignees
No one assigned
Labels
enhancements New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ferrine @ricardoV94 @twiecki @ColCarroll