Model Builder refactoring #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelraczycki
changed the title
twiecki
reviewed
Mar 31, 2023
twiecki
reviewed
Mar 31, 2023
twiecki
reviewed
Mar 31, 2023
twiecki
reviewed
Mar 31, 2023
twiecki
reviewed
Mar 31, 2023
|
@michaelraczycki Can you give an informative title to the PR and commits (in case it makes it into the release notes)? To avoid issues like the one you just had, I suggest you keep your PR git history clean. Just squash commits that belong together if you are doing incremental changes/fixes. This way you won't have to sort the same conflicts 100s of times ;) Also rebasing from main instead of merging can help. |
michaelraczycki
changed the title
|
@ricardoV94 I'll make sure to make more granular commits from now on and make them more descriptive |
|
@twiecki requested changes are in. Do you think we should keep this PR as draft and keep adding on top of the present changes, or keep merging and opening new PR's? |
twiecki
reviewed
Mar 31, 2023
twiecki
reviewed
Mar 31, 2023
twiecki
reviewed
Mar 31, 2023
twiecki
reviewed
Mar 31, 2023
|
That looks great now! |
twiecki
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New branch containing changes from #119, created because of unexpected problems with rebasing done in order to cover CI test bugs.