Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model builder tests #114

Merged
merged 7 commits into from
Mar 5, 2023
Merged

Conversation

michaelraczycki
Copy link
Collaborator

Extending the model_builder test suite

@michaelraczycki
Copy link
Collaborator Author

@twiecki , let me know if you'd do something differently in the unit tests, I've decided to go first with full tests before trying to integrate with baseMMM class

data, model_config, sampler_config = test_ModelBuilder.create_sample_input()
model = test_ModelBuilder(model_config, sampler_config, data)
model.fit()
model = test_ModelBuilder.initial_build_and_fit(False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

@twiecki twiecki merged commit 84aa791 into pymc-devs:main Mar 5, 2023
@twiecki
Copy link
Member

twiecki commented Mar 5, 2023

Thanks 👍

@michaelraczycki
Copy link
Collaborator Author

Glad to help

@michaelraczycki michaelraczycki deleted the model_builder_tests branch March 31, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants