-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default_model_config form @property to @staticmethod #225
Comments
This looks like something I could do, though I'd like to ask some clarification. It seems that starting in Python 3.11, |
Hello @pdb5627, we don't want to chain the decorators, but only replace it (@property->@staticmethod). The main purpose of it is to remove the necesity of initialization of a model to see the default values from the user's standpoint. Yes, I think that the change to a verb should be done, but also it would require searching through the LinearModel and tests to replace it there |
Fixes pymc-devs#225. Since the method changed from a property to a method, it was renamed from a noun to a verb. Both `default_model_config` and `default_sampler_config` were changed.
* Change default_*_config from @Property to @staticmethod Fixes #225. Since the method changed from a property to a method, it was renamed from a noun to a verb. Both `default_model_config` and `default_sampler_config` were changed. * Fix to use staticmethod instead of classmethod
Current design is shorter for usage inside the classes themselves, but when it comes to end user experience it forces initialization of the model class to take a look at customizable variables
The text was updated successfully, but these errors were encountered: