Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blackjax SMC integration #374

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

ciguaran
Copy link
Contributor

Fixes #354

@ciguaran
Copy link
Contributor Author

@ricardoV94 do you have any insight on pytensor's E AttributeError: A config parameter with the name 'floatX' was already registered on another config instance. ? I can't seem to reproduce it locally with python 3.10. Locally all tests pass.

@ricardoV94
Copy link
Member

@ciguaran I don't think it's related to your changes. Perhaps something @Armavica changed in PyTensor recently?

@Armavica
Copy link
Member

Armavica commented Aug 21, 2024

We talked about it with @ferrine some time ago. It started happening around the time of #361 so it could be related to that too.
The error happens on my computer too. I remember I tried bisecting pymc-experimental, including downgrading pytensor, but didn't manage to understand what caused it.

@ricardoV94
Copy link
Member

Rebasing may magically solve the failures now

@ciguaran
Copy link
Contributor Author

ciguaran commented Oct 7, 2024

@ricardoV94 it seems so!

@ricardoV94 ricardoV94 changed the title Fixes Blackjax SMC integration after bump Fix Blackjax SMC integration Oct 7, 2024
@ricardoV94 ricardoV94 merged commit 7815e5b into pymc-devs:main Oct 7, 2024
7 checks passed
@ricardoV94
Copy link
Member

Thanks @ciguaran !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blacjax SMC test is failing
3 participants