Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement limit case of R2D2M2CP for P #182

Merged
merged 19 commits into from
Jun 26, 2023
Merged

Implement limit case of R2D2M2CP for P #182

merged 19 commits into from
Jun 26, 2023

Conversation

ferrine
Copy link
Member

@ferrine ferrine commented May 31, 2023

close #170 to enable strict coefficient sign in the model

with pm.Model(coords=dict(a=range(2))) as model:
    std, beta = pmx.distributions.R2D2M2CP(
        "beta1",
        1,
        [1, 1],
        dims="a",
        r2=0.8,
        r2_std=0.1,
        positive_probs=[0.5, 0],
        positive_probs_std=[0.3, 0],
        centered=False,
    )
image

@ferrine ferrine changed the title add helper function to initialize masked psi Implement limit case of R2D2M2CP for P->0 or P->1 May 31, 2023
@ferrine ferrine changed the title Implement limit case of R2D2M2CP for P->0 or P->1 Implement limit case of R2D2M2CP for P May 31, 2023
@ricardoV94
Copy link
Member

Failing test should be fixed by #183

@ferrine
Copy link
Member Author

ferrine commented Jun 5, 2023

Just rebased

@ferrine
Copy link
Member Author

ferrine commented Jun 5, 2023

I found an issue if all the positive_probs are at the limit case

@ferrine ferrine requested a review from ricardoV94 June 22, 2023 20:12
@ferrine ferrine merged commit 356232c into main Jun 26, 2023
@ferrine ferrine deleted the R2D2M2CP-0 branch June 26, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement strict sign for r2d2m2cp
2 participants