Skip to content

Fix img path issues - #703

Merged
twiecki merged 3 commits into
pymc-devs:mainfrom
B-Deforce:fix/path-issue
Oct 4, 2024
Merged

Fix img path issues#703
twiecki merged 3 commits into
pymc-devs:mainfrom
B-Deforce:fix/path-issue

Conversation

@B-Deforce

@B-Deforce B-Deforce commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

The following images pooled.png, unpooled.png, and partial_pooled_model.png were wrongly assumed to reside in the same folder as the notebook and referred to as such in the notebook. Instead, they are located in ../case_studies/. These paths have now been fixed.


📚 Documentation preview 📚: https://pymc-examples--703.org.readthedocs.build/en/703/

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OriolAbril

Copy link
Copy Markdown
Member

Thanks! Can you instead move the images to the generalized linear models folder? The notebook used to be in the case studies folder: https://github.com/pymc-devs/pymc-examples/tree/bed70e39355b6f4286b1c7aafa337e23bffa612b/examples/case_studies and it looks like it was moved without the images. Now that you have pointed out the issue, I don't think it makes sense to continue keeping the images in a different folder

@B-Deforce

Copy link
Copy Markdown
Contributor Author

You're right, moving the images makes more sense. Fixed it :).

@juanitorduz
juanitorduz requested a review from OriolAbril October 3, 2024 19:20
@twiecki
twiecki merged commit fc03395 into pymc-devs:main Oct 4, 2024
@B-Deforce
B-Deforce deleted the fix/path-issue branch October 4, 2024 07:25
fonnesbeck pushed a commit to fonnesbeck/pymc-examples that referenced this pull request Dec 20, 2024
* fix img path issues

* fix img path issues

* fix img path issues
fonnesbeck pushed a commit to fonnesbeck/pymc-examples that referenced this pull request Jan 19, 2025
* fix img path issues

* fix img path issues

* fix img path issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants