Use vanilla entities in pylon entity block holder #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAHuman-xD
requested changes
Sep 28, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/item/builder/ItemStackBuilder.kt
Outdated
Show resolved
Hide resolved
Seggan
approved these changes
Sep 29, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/item/builder/ItemStackBuilder.kt
Outdated
Show resolved
Hide resolved
Member
|
(other than Justin's comments) |
Merged
JustAHuman-xD
requested changes
Oct 3, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/fluid/PylonFluid.kt
Outdated
Show resolved
Hide resolved
JustAHuman-xD
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows vanilla entities to be used in PylonEntityHolderBlock. Support for Pylon entities in PylonEntityHolderBlock still exists.
This simplifies entity holder blocks slightly by removing the requirement to wrap displays in Pylon entities, as we were doing before with SimpleItemDisplay / etc
Also adds methods to ItemStackBuilder to allow editing custom model data, and adds custom model data to fluid pipe displays and fluid connection point displays.
closes #295