Skip to content

feat(desktop): share Pylon macOS permission onboarding - #505

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-09-12-mac-permissions
Sep 12, 2026
Merged

feat(desktop): share Pylon macOS permission onboarding#505
rynfar merged 1 commit into
pylonfrom
upstream/2026-09-12-mac-permissions

Conversation

@rynfar

@rynfar rynfar commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Safari import and snapshot setup now share a macOS permission checklist and a small native helper that lets users drag the packaged Pylon app into System Settings. Continue stays explicit and waits for required grants; status polling pauses while hidden, avoids overlapping checks, and rejects stale grants after errors. One scoped service owns the helper, watcher process, timers, and IPC listener.

Cycle #497, frozen range 6c583620ff7ad3235b135af7107c0543467eecfa..4a4c6dd2adc350a68ba18bb28b24b5a7e4660dab. Adopted 36668dbe4fe2f8c881cc4f93bc675413eef1406f.

Pylon adaptations retain app naming/icon and desktop identities, current snapshot settings behavior, Linux and Windows browser-import support, named Safari profiles, and profile documentation. The helper preload is separately bundled and sandboxed. Permission probing only opens/closes the Safari cookie file; it does not read/import cookies. Existing external URL restrictions remain unchanged.

Validation: 159 focused tests across seven suites; desktop, web, and contracts typechecks; changed-file lint (three existing SnapShotSettings effect warnings), formatting, and successful desktop vp pack, including the standalone permission preload. Initial vp build attempts used the wrong desktop command and were replaced by the configured pack command.

Upstream visual evidence and limitations: pingdotgg/t3code#11289. No rendered Pylon screenshot, native permission/drop run, or browser/computer use was performed; native integrated visual verification remains outstanding. No release or install.

Implemented with GPT-6 in Codex.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Sep 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pylon-marketing Ready Ready Preview Sep 12, 2026 6:34am UTC

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Sep 12, 2026
@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 14.0 KiB 14.1 KiB +69 B (+0.5%) 15.1 KiB
Codex Thread snapshot wire 7.2 KiB 7.2 KiB +1 B (+0.0%) 7.3 KiB
Codex Live turn WebSocket wire 6.8 KiB 6.9 KiB +68 B (+1.0%) 7.8 KiB
Codex Live turn WebSocket decoded 58.8 KiB 58.8 KiB +88 B (+0.1%) 66.4 KiB
Codex Live turn messages 8 10 +2 (+25.0%) 21
Claude Total thread wire 14.0 KiB 14.1 KiB +83 B (+0.6%) 15.1 KiB
Claude Thread snapshot wire 7.2 KiB 7.2 KiB −2 B (−0.0%) 7.3 KiB
Claude Live turn WebSocket wire 6.8 KiB 6.9 KiB +85 B (+1.2%) 7.8 KiB
Claude Live turn WebSocket decoded 59.6 KiB 59.7 KiB +88 B (+0.1%) 66.4 KiB
Claude Live turn messages 8 10 +2 (+25.0%) 21

Baseline: 723acaf · PR result: 702d824 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 115.6 KiB
  • Claude decoded thread snapshot: 116.3 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

(cherry picked from commit 36668dbe4fe2f8c881cc4f93bc675413eef1406f)
@rynfar

rynfar commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator Author

Independent review completed for macOS permission onboarding, with no remaining findings. Reviewed the sandboxed helper CSP and main-frame IPC guard, owned JXA process lifecycle, escaping and Pylon identity, permission poll cleanup/visibility, packaging, and Browser Import/SnapShot consumers. Rebase range-diff confirms the shared MacPermission settings map composes with the already landed encoded-Zed validation. 159 focused tests, scoped types and package build passed; final head 702d824 has green CI. Native visual verification remains unperformed as stated in the PR. Landing under standing upstream-cycle approval.

@rynfar
rynfar merged commit ab635d5 into pylon Sep 12, 2026
20 checks passed
@rynfar
rynfar deleted the upstream/2026-09-12-mac-permissions branch September 12, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants