feat(desktop): share Pylon macOS permission onboarding - #505
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
(cherry picked from commit 36668dbe4fe2f8c881cc4f93bc675413eef1406f)
cc219ed to
702d824
Compare
|
Independent review completed for macOS permission onboarding, with no remaining findings. Reviewed the sandboxed helper CSP and main-frame IPC guard, owned JXA process lifecycle, escaping and Pylon identity, permission poll cleanup/visibility, packaging, and Browser Import/SnapShot consumers. Rebase range-diff confirms the shared MacPermission settings map composes with the already landed encoded-Zed validation. 159 focused tests, scoped types and package build passed; final head 702d824 has green CI. Native visual verification remains unperformed as stated in the PR. Landing under standing upstream-cycle approval. |
Safari import and snapshot setup now share a macOS permission checklist and a small native helper that lets users drag the packaged Pylon app into System Settings. Continue stays explicit and waits for required grants; status polling pauses while hidden, avoids overlapping checks, and rejects stale grants after errors. One scoped service owns the helper, watcher process, timers, and IPC listener.
Cycle #497, frozen range
6c583620ff7ad3235b135af7107c0543467eecfa..4a4c6dd2adc350a68ba18bb28b24b5a7e4660dab. Adopted36668dbe4fe2f8c881cc4f93bc675413eef1406f.Pylon adaptations retain app naming/icon and desktop identities, current snapshot settings behavior, Linux and Windows browser-import support, named Safari profiles, and profile documentation. The helper preload is separately bundled and sandboxed. Permission probing only opens/closes the Safari cookie file; it does not read/import cookies. Existing external URL restrictions remain unchanged.
Validation: 159 focused tests across seven suites; desktop, web, and contracts typechecks; changed-file lint (three existing SnapShotSettings effect warnings), formatting, and successful desktop
vp pack, including the standalone permission preload. Initialvp buildattempts used the wrong desktop command and were replaced by the configured pack command.Upstream visual evidence and limitations: pingdotgg/t3code#11289. No rendered Pylon screenshot, native permission/drop run, or browser/computer use was performed; native integrated visual verification remains outstanding. No release or install.
Implemented with GPT-6 in Codex.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.