test(web): cancel pending highlight frames before restoring globals - #388
Merged
Merged
Conversation
…0188) (cherry picked from commit f8b4c464b4760d73e0ece7e68011c738803d8b69)
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File-editor highlighting tests can finish successfully and then fail CI when a queued worker broadcast runs after browser globals have been removed. Cancel the fixture’s remaining animation frames after its real workers terminate, and keep the existing highlighting assertions.
Adopts pingdotgg/t3code#10188 (
f8b4c464b4760d73e0ece7e68011c738803d8b69). The controlled regression reproducescancelAnimationFrame is not definedwhen frame cancellation is removed; all 8 tests pass with the fix. Web typecheck, scoped lint, formatting, and diff checks pass. Production behavior is unchanged, so client screenshots do not apply.Model: GPT-6 Astra. Harness: Codex.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.