fix(mobile): keep review usable without its native diff view - #383
Merged
Conversation
…diff fallback (#9828) Co-authored-by: James <jamescollard2005@gmail.com> (cherry picked from commit bc3dc2694b5d15613ef610d693d18ebd904b0d56)
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a parsed diff can crash when the native diff view has not registered or is missing from the installed mobile binary. Fall back to its raw patch, hide the navigator that cannot scroll that fallback, and provide pull-to-refresh through the existing refresh handler.
Adopts pingdotgg/t3code#9828 (
bc3dc2694b5d15613ef610d693d18ebd904b0d56) with Pylon's current review screen, theme, navigation, and connection handling. The native diff path remains available when registered. This is JavaScript-only and does not change the fingerprint policy or native dependency set.Validation: mobile
tsc --noEmit, scoped lint and the existing focused review availability, pane-selection and model tests pass. An integrated iPhone 17 Pro / iOS 26.3 check reproduced the null-component crash before the fix, rendered the raw patch after the fix, and loaded changed fixture contents with a native pull-to-refresh gesture. Restoring normal native resolution returned to the native diff surface. Temporary fault injection was removed; the integrated mobile package typecheck passed. Android shares this component but was not exercised in a device runtime. Before/after images and the refresh video are attached below. Web/desktop are unaffected; review behavior is independent of the provider and still uses the selected environment.Native pull-to-refresh recording.
Model: GPT-6 Astra. Harness: Codex.