fix(auth): keep pairing credentials out of link listings - #323
Merged
Conversation
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
(cherry picked from commit 9d28c21a26aeef198cb064fe466e49cbeabfe09c)
rynfar
force-pushed
the
upstream/2026-09-06-pairing-link-metadata
branch
from
September 6, 2026 18:35
ff28e44 to
5e97143
Compare
rynfar
marked this pull request as ready for review
September 6, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairing-link listings currently return credentials that let someone join an environment. This change returns link metadata for listing and revocation, while keeping the credential available only in the response that creates a new link. Pylon’s Share panel, endpoint selection, QR code, and copy actions continue to work for newly created links during the current Settings visit.
Selectively adopts upstream pingdotgg/t3code#9523 (9d28c21a26aeef198cb064fe466e49cbeabfe09c). Existing links can still be listed and revoked; create a new link after leaving Settings to share again. The user guide explains this behavior.
Validation: 193 focused tests across server authorization, pairing storage and wire responses, CLI formatting, client authorization, pairing URLs, and Connections settings; scoped contracts, client-runtime, server, web, and mobile typechecks; changed-file lint. Rebased server authorization tests rerun against the connection-renewal changes. Integrated client verification completed; evidence below.
Integrated sandbox verification created an actual pairing link. The baseline still offered Copy code after reload. The candidate offered Copy code only immediately after creation, then retained metadata and Revoke after reload with no copy control. The sandbox remained bound to loopback; a renderer-only remote-policy fixture exposed the Connections controls. After the final rebase, 167 server authorization tests passed.
Model: GPT-6 Astra. Harness: Codex.