fix(server): bound live event buffers for slow clients - #293
Merged
Conversation
(cherry picked from commit 108f295cc3672716c3cb8291ce487846df5ce098)
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slow or disconnected client could retain an unbounded queue of live events and exhaust the Pylon server’s memory. Bound each shell/thread subscription to 1,000 items and 8 MiB, including coalesced batches and the batch awaiting acknowledgement. Overflow detaches the producer immediately and returns the existing recoverable stream error so clients resume from their last applied sequence.
Adopts approved B2, upstream #9715, 108f295cc3672716c3cb8291ce487846df5ce098. Preserves Pylon’s startup subscription attachment, replay ordering, deletion recovery and rollback event routing. Authoritative snapshots stay outside the live-event budget. Applies to every provider and web, desktop and mobile, including remote/relay/tunnel connections.
Validation: 166 focused budget, coalescer and WebSocket server tests plus 18 shared client synchronization/error tests pass. Held-ACK tests verify producer cleanup before acknowledgement and exact replay/deletion recovery. Scoped server/client-runtime types, targeted lint and diff checks pass. No live environment state was used.
Model: GPT-6 Astra. Harness: Codex.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.