Cleanup variables checker#9978
Merged
jacobtylerwalls merged 4 commits intoSep 29, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9978 +/- ##
==========================================
- Coverage 95.80% 95.80% -0.01%
==========================================
Files 174 174
Lines 18940 18934 -6
==========================================
- Hits 18146 18140 -6
Misses 794 794
|
Contributor
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 208b434 |
jacobtylerwalls
approved these changes
Sep 29, 2024
Member
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Thanks! Reducing complexity debt in the variables checker is important. I've contributed at least a dozen times and still find it forbidding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
The variables checker contains some really complicated code (complicated in a bad way). It is difficult to understand and therefore difficult to modify. I became keenly aware of this over the course of several failed attempts to implement #9964. The complicatedness of this code may also account for why #8893 remains open.
This MR makes a few minor changes in the direction of cleaning up the variables checker. It should make no functional difference.
There are more changes that need to be made, but it preferable that MRs be small. So this is the first of several.
Each commit makes one specific change, so the commits should be reviewed one at a time.