Cleanup test skips #9773
Merged
Cleanup test skips #9773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
Maintenance
jacobtylerwalls
commented
Jul 7, 2024
| @@ -1,3 +1,3 @@ | |||
| [testoptions] | |||
| max_pyver=3.8 | |||
There was a problem hiding this comment.
Added in #9034, but I think the idea was to run this test on 3.8, not skip it on 3.8.
max_pyver is actually pretty confusingly named.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9773 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 174 174
Lines 18878 18878
=======================================
Hits 18094 18094
Misses 784 784 |
DanielNoord
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
In preparation for dropping 3.8 support on main (#9774), clean up some items that were missed in previous rounds.