Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also check Lambda for await-outside-async #9653

Merged

Conversation

UTsweetyfish
Copy link
Contributor

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Also check Lambda for await-outside-async.

@UTsweetyfish UTsweetyfish force-pushed the await-outside-async-lambda branch from 4597886 to d43e3c7 Compare May 19, 2024 12:29

This comment has been minimized.

@UTsweetyfish UTsweetyfish force-pushed the await-outside-async-lambda branch from d43e3c7 to 482f3f5 Compare May 19, 2024 12:40
@jacobtylerwalls jacobtylerwalls added this to the 3.3.0 milestone May 19, 2024
@jacobtylerwalls jacobtylerwalls added the False Negative πŸ¦‹ No message is emitted but something is wrong with the code label May 19, 2024
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.86%. Comparing base (978981d) to head (0582238).
Report is 147 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9653   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         174      174           
  Lines       18907    18907           
=======================================
  Hits        18125    18125           
  Misses        782      782           
Files Coverage Ξ”
pylint/checkers/typecheck.py 96.62% <100.00%> (ΓΈ)

This comment has been minimized.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward, thank you. Could you simply add a fragment for a false negative ? As there's no related issue you can ref this MR directly in the fragment with Refs #9653.

@UTsweetyfish
Copy link
Contributor Author

Looks straightforward, thank you. Could you simply add a fragment for a false negative ? As there's no related issue you can ref this MR directly in the fragment with Refs #9653.

Can you add that for me? I don't have towncrier installed. Thanks!

@Pierre-Sassoulas
Copy link
Member

You can copy paste a file in https://github.com/pylint-dev/pylint/tree/main/doc/whatsnew/fragments and name it 9653.false_negative :)

@UTsweetyfish UTsweetyfish force-pushed the await-outside-async-lambda branch from 6617d51 to 0582238 Compare May 20, 2024 02:33
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first contribution thank you !

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) May 20, 2024 05:26
@Pierre-Sassoulas Pierre-Sassoulas disabled auto-merge May 20, 2024 05:26
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) May 20, 2024 05:26
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 0582238

@Pierre-Sassoulas Pierre-Sassoulas merged commit adf0535 into pylint-dev:main May 20, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Negative πŸ¦‹ No message is emitted but something is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants