-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Feature] Add filepaths checked to verbose msg #9375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would probably make sense to store this in _stats
. The data is probably already there, we just need to print it.
I do think this is a good change though 😊
@DanielNoord I've moved the names set to the LinterStats class. Don't know if there is other way but currently the information of modules that the stats class has it's not straightforward readable. e.g. if we run pylint over a directory
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. We know only need a changelog entry and update some failing tests.
This comment has been minimized.
This comment has been minimized.
97544ab
to
cde7da3
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Alvaro Frias Garay <[email protected]>
Signed-off-by: Alvaro Frias Garay <[email protected]>
cde7da3
to
b1f6ab3
Compare
This comment has been minimized.
This comment has been minimized.
I'm working on this, please do not merge. I don't think the verbose output should be generated AT the end but during collection instead. But there's a mess of duplication to deal with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9375 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 175 175
Lines 19082 19086 +4
=======================================
+ Hits 18299 18303 +4
Misses 783 783
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit f80c541 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you think that we should display what we're going to parse before actually parsing Daniel ? (I don't like that we have a stat file that we're going to have to keep consistent across multiple thread when we have all the information before creating the AST)
I think we could do that as a follow up. This seems pretty useful as is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough.
Going to refactor the arg parsing "later" ™️ and multithreading is already broken
Signed-off-by: Alvaro Frias Garay <[email protected]> Co-authored-by: Pierre Sassoulas <[email protected]> Co-authored-by: Jacob Walls <[email protected]> Co-authored-by: Daniël van Noord <[email protected]>
Type of Changes
Description
Update the verbose output of the linter by including the filenames of the files that have been checked. Previously, the verbose output only included the count of checked and skipped files. With this change, users can now see exactly which files have been processed by the linter.
Closes #9357