Fix a false positive for bad-dunder-name
#8619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyrnepr2
added
the
False Positive π¦
This comment has been minimized.
This comment has been minimized.
mbyrnepr2
force-pushed
the
8613_bad_dunder_name
branch
from
1329e35
to
ea61dc9
Compare
β¦ined ``__index__`` method. Closes pylint-dev#8613
mbyrnepr2
force-pushed
the
8613_bad_dunder_name
branch
from
ea61dc9
to
94cd2e3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8619 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 174 174
Lines 18416 18416
=======================================
Hits 17664 17664
Misses 752 752
|
Pierre-Sassoulas
requested changes
Apr 24, 2023
Pierre-Sassoulas
approved these changes
Apr 24, 2023
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 94cd2e3 |
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Apr 24, 2023
β¦ined ``__index__`` method. (#8619) (#8622) Closes #8613 (cherry picked from commit f223c6d) Co-authored-by: Mark Byrne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a false positive for
bad-dunder-namewhen there is a user-defined__index__method.Closes #8613