[testutil] Add proper test for the functional tests helpers

[Pierre-Sassoulas]

Type of Changes

	Type
✓	✨ New feature

Description

Required for #8474, the output update was been broken a lot previously. We don't need the user warning because either we're going to fail with a message telling to update the output or we're already going to update the output.

[codecov]

Codecov Report

Merging #8484 (0ff5d86) into main (eeb3eec) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 0ff5d86 differs from pull request most recent head 8f0de6d. Consider uploading reports for the commit 8f0de6d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8484      +/-   ##
==========================================
+ Coverage   95.81%   95.91%   +0.09%     
==========================================
  Files         174      174              
  Lines       18334    18365      +31     
==========================================
+ Hits        17567    17615      +48     
+ Misses        767      750      -17     

Impacted Files	Coverage Δ
pylint/testutils/output_line.py	97.05% <ø> (-2.95%)	⬇️
...lint/testutils/functional/find_functional_tests.py	100.00% <100.00%> (ø)
pylint/testutils/lint_module_test.py	94.35% <100.00%> (+9.74%)	⬆️

[DanielNoord]

I left some early comments. Note that I find it quite hard to review, feels like a lot of refactoring and actual code changes are included here. Perhaps split the refactoring + fixes and the adding of tests in two separate PRs?

[Pierre-Sassoulas]

Created #8490 to simplify the review.

[DanielNoord]

Thanks @Pierre-Sassoulas! Wonderful that all of this code is finally getting tested.

I reviewed this commit by commit as just final diff is still quite large. I think it is probably best to go through them commit by commit as well as the comments make more sense then!

Again, love this! Makes it much easier to use this for plugins as well!

[DanielNoord]

Sorry for taking so long to review this! Hard to find the time to get back into this. Think we are getting there though! Love the idea of all of this being actually tested 😄

[DanielNoord]

Thanks again @Pierre-Sassoulas for all the work that went into this!

[Pierre-Sassoulas]

I'm going to cleanup and rebase :)

[DanielNoord]

I'm going to cleanup and rebase :)

I'll be right here to approve and let auto-merge do its magic 😄

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 8f0de6d