[deprecation] Remove get_message_definitions from BaseChecker

[Pierre-Sassoulas]

Type of Changes

	Type
✓	🔨 Refactoring
✓	📜 Docs

Description

[codecov]

Codecov Report

Merging #8401 (98f7de3) into main (491c539) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8401      +/-   ##
==========================================
- Coverage   95.59%   95.59%   -0.01%     
==========================================
  Files         177      177              
  Lines       18696    18688       -8     
==========================================
- Hits        17873    17865       -8     
  Misses        823      823              

Impacted Files	Coverage Δ
pylint/checkers/base_checker.py	95.27% <ø> (-0.28%)	⬇️

[ollie-iterators]

Since things for pylint 3.0.0 are being merged, does that mean that nothing is going to happen with pylint 2.17.1? (If so then IMHO https://github.com/PyCQA/pylint/milestone/90 should be closed)

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on django:
The following messages are no longer emitted:

Details

1. redefined-variable-type:
   Redefinition of field type from django.db.models.fields.related.OneToOneField to django.forms.widgets.Widget
   https://github.com/django/django/blob/279e611c017b5fcc055263e760de1495a9098ede/django/db/models/base.py#L346

Effect on music21:
The following messages are now emitted:

Details

1. invalid-name:
   Attribute name "id" doesn't conform to '[a-z_][A-Za-z0-9_]{2,30}$' pattern
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/prebase.py#L293
2. suppressed-message:
   Suppressed 'attribute-defined-outside-init' (from line 3193)
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3193
3. suppressed-message:
   Suppressed 'attribute-defined-outside-init' (from line 3264)
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3264
4. too-many-instance-attributes:
   Too many instance attributes (34/20)
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/roman.py#L1394
5. redefined-variable-type:
   Redefinition of sc3 type from music21.scale.MajorScale to music21.scale.MinorScale
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/scale/test_scale_main.py#L169
6. suppressed-message:
   Suppressed 'method-hidden' (from line 11551)
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/stream/base.py#L11552

The following messages are no longer emitted:

Details

1. invalid-name:
   Attribute name "id" doesn't conform to '[a-z_][A-Za-z0-9_]{2,30}$' pattern
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L576
2. useless-suppression:
   Useless suppression of 'attribute-defined-outside-init'
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3193
3. useless-suppression:
   Useless suppression of 'attribute-defined-outside-init'
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3264
4. redefined-variable-type:
   Redefinition of fundamental type from django.forms.widgets.Widget to music21.pitch.Pitch
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/pitch.py#L3690
5. too-many-instance-attributes:
   Too many instance attributes (33/20)
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/roman.py#L1394
6. redefined-variable-type:
   Redefinition of lastChord type from music21.chord.Chord to django.forms.widgets.Widget
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/analysis/neoRiemannian.py#L435
7. redefined-variable-type:
   Redefinition of n type from music21.note.Note to music21.note.GeneralNote
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/abcFormat/translate.py#L354
8. redefined-variable-type:
   Redefinition of sc3 type from music21.scale.MinorScale to music21.scale.MajorScale
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/scale/test_scale_main.py#L163
9. useless-suppression:
   Useless suppression of 'method-hidden'
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/stream/base.py#L11551

Effect on pandas:
The following messages are now emitted:

Details

1. redefined-variable-type:
   Redefinition of expected type from pandas.core.arrays.numpy_.PandasArray to pandas.core.indexes.base.Index
   https://github.com/pandas-dev/pandas/blob/376f77da131bb45147ea67009b65ffbad59e4945/pandas/_testing/__init__.py#L299

The following messages are no longer emitted:

Details

1. redefined-variable-type:
   Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.indexes.base.Index
   https://github.com/pandas-dev/pandas/blob/376f77da131bb45147ea67009b65ffbad59e4945/pandas/_testing/__init__.py#L299

This comment was generated for commit 98f7de3

[Pierre-Sassoulas]

We're maintaining the last minor version in general but even when we release a major. So we're going to maintain 2.x until we release 3.0, possibly for another minor, see #7607