Skip to content

Suppress stop-iteration-return on itertools.cycle#7766

Merged
Pierre-Sassoulas merged 6 commits intopylint-dev:mainfrom
tushar-deepsource:fp-itertools-cycle
Nov 14, 2022
Merged

Suppress stop-iteration-return on itertools.cycle#7766
Pierre-Sassoulas merged 6 commits intopylint-dev:mainfrom
tushar-deepsource:fp-itertools-cycle

Conversation

@tushar-deepsource
Copy link
Copy Markdown
Contributor

Type of Changes

Type
🐛 Bug fix

Description

Closes #7765

@Pierre-Sassoulas Pierre-Sassoulas added Needs review 🔍 Needs to be reviewed by one or multiple more persons False Positive 🦟 A message is emitted but nothing is wrong with the code Work in progress and removed Needs review 🔍 Needs to be reviewed by one or multiple more persons labels Nov 14, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix, thank you 👌

Comment thread doc/whatsnew/fragments/7766.false_positive Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 14, 2022

Pull Request Test Coverage Report for Build 3461793425

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.403%

Totals Coverage Status
Change from base Build 3460107264: 0.0%
Covered Lines: 17348
Relevant Lines: 18184

💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer and removed Work in progress labels Nov 14, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.6 milestone Nov 14, 2022
@github-actions
Copy link
Copy Markdown
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 3a05b09

@Pierre-Sassoulas Pierre-Sassoulas merged commit 6de674c into pylint-dev:main Nov 14, 2022
Pierre-Sassoulas added a commit that referenced this pull request Nov 16, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Nov 16, 2022
Pierre-Sassoulas added a commit that referenced this pull request Nov 17, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stop-iteration-return false positive when using itertools.cycle

3 participants