Skip to content

Confirm changes before tbump commit#7666

Merged
Pierre-Sassoulas merged 1 commit into
pylint-dev:mainfrom
cdce8p:tbump-confirm
Oct 23, 2022
Merged

Confirm changes before tbump commit#7666
Pierre-Sassoulas merged 1 commit into
pylint-dev:mainfrom
cdce8p:tbump-confirm

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Oct 23, 2022

Description

Add an additional tbump step to confirm changes before the commit is created.
Found this to be quite helpful when I was doing the patch release.

Refs: https://stackoverflow.com/questions/1885525/how-do-i-prompt-a-user-for-confirmation-in-bash-script

@cdce8p cdce8p added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Oct 23, 2022
@cdce8p cdce8p added this to the 2.15.6 milestone Oct 23, 2022
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3307821526

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.358%

Totals Coverage Status
Change from base Build 3307801309: 0.0%
Covered Lines: 17172
Relevant Lines: 18008

💛 - Coveralls

Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 38fa174 into pylint-dev:main Oct 23, 2022
@cdce8p cdce8p deleted the tbump-confirm branch October 23, 2022 17:20
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants