fix astroid-error for parsing module encoding#7663
Merged
Pierre-Sassoulas merged 3 commits intoOct 23, 2022
Conversation
clavedeluna
commented
Oct 22, 2022
| if not encoding.startswith("utf"): | ||
| if encoding not in UNICODE_BOMS: | ||
| return encoded | ||
| bom = UNICODE_BOMS[encoding] |
Contributor
Author
There was a problem hiding this comment.
since all UNICODE_BOMS are utf..., it's redundant to check if it starts with utf. Just checking if encoding is in UNICODE is sufficient and prevents unsafe KeyError
Pull Request Test Coverage Report for Build 3307142525
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
added
Needs backport
Pierre-Sassoulas
requested changes
Oct 22, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
approved these changes
Oct 23, 2022
Contributor
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 416bc99 |
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
added a commit
that referenced
this pull request
Nov 16, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas
added a commit
that referenced
this pull request
Nov 17, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix dict operation bug when parsing module to determine module encoding. Also added tests not previously added when handling this issue in #7097
Closes #7661