Fix a crash in unnecessary-list-index-lookup when incorrectly using enumerate()#6604
Merged
Merged
Conversation
jacobtylerwalls
added
Needs backport
jacobtylerwalls
changed the title
unnecessary-list-index-lookup when incorrectly using…unnecessary-list-index-lookup when incorrectly using enumerate()
Merged
Pull Request Test Coverage Report for Build 2319539682
💛 - Coveralls |
Member
|
I got a 80 lines function conflicting to add here during the cherry-pick on 2.13. I did not understand precisely why... I wonder if it's also going to add "feature" to the 2.13 branch. Also 3 check in the functional test for unnecessary index lookup are not passing, probably because of other bug fixes that are only in 2.14. Do you think it's worth it to fix the cherry-pick @jacobtylerwalls ? |
Member
|
It's possible that the crash was introduced in 2.14 in the conflicting function. |
Member
Author
|
Oops, sorry, you're right, this entire check was a new feature in 2.14! |
jacobtylerwalls
removed
the
Needs backport
Member
Author
|
I'll remove the release note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #6603