Fix false positive for undefined-loop-variable with enumerate()#6602
Merged
Pierre-Sassoulas merged 2 commits intoMay 13, 2022
Merged
Conversation
jacobtylerwalls
added
Bug 🪲
Needs backport
Pull Request Test Coverage Report for Build 2319787404
💛 - Coveralls |
Merged
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas
approved these changes
May 13, 2022
Member
|
Good job "sneaking" two crash fixes in the last python 3.6 release 😉 At some point I'm pretty sure that some poor dev working on EOL python with unruly legacy enumerate, will thank you for that. |
Pierre-Sassoulas
added a commit
that referenced
this pull request
May 13, 2022
…6602) Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
added a commit
that referenced
this pull request
May 13, 2022
…6602) Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #6593