Skip to content

Fix a crash in unnecessary-dict-index-lookup when subscripting an attribute#6579

Merged
Pierre-Sassoulas merged 1 commit into
pylint-dev:mainfrom
jacobtylerwalls:subscript-attribute
May 11, 2022
Merged

Fix a crash in unnecessary-dict-index-lookup when subscripting an attribute#6579
Pierre-Sassoulas merged 1 commit into
pylint-dev:mainfrom
jacobtylerwalls:subscript-attribute

Conversation

@jacobtylerwalls
Copy link
Copy Markdown
Member

Type of Changes

Type
🐛 Bug fix

Description

Closes #6557

@jacobtylerwalls jacobtylerwalls added the Crash 💥 A bug that makes pylint crash label May 11, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.13.9 milestone May 11, 2022
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2307091814

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 95.333%

Totals Coverage Status
Change from base Build 2305618450: 0.006%
Covered Lines: 16037
Relevant Lines: 16822

💛 - Coveralls

Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line fix with 15 line of doc/tests, nice ratio ! 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 5fcccc1 into pylint-dev:main May 11, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label May 11, 2022
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels May 11, 2022
@jacobtylerwalls jacobtylerwalls deleted the subscript-attribute branch May 12, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported Crash 💥 A bug that makes pylint crash

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash 'Attribute' object has no attribute 'name'

4 participants