Respect ignore configuration options when --recursive=y.#6528
Respect ignore configuration options when --recursive=y.#6528matusvalo merged 18 commits intopylint-dev:mainfrom
Conversation
Pull Request Test Coverage Report for Build 2317639935
💛 - Coveralls |
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Great, thank you @matusvalo.
With the release of 2.14 approaching I'm taking the opportunity to ask you semi-publicly here (as your shown email is a no-reply):
I've been impressed with your tenacity in getting the deprecation checks, documentation, and especially the recursive option changes. Your general contributions to pylint, is outstanding and I was wondering if you'd be interested in having commit rights to pylint and astroid.
This would allow you a great flexibility in terms of reviewing, triaging or simply getting your code in the repo faster.
Let me know if that would be of any interest to you.
DanielNoord
left a comment
There was a problem hiding this comment.
Thanks @matusvalo!
Just some small recommendations.
| assert not ex.value.code % 2 | ||
|
|
||
| def test_regression_recursive(self): | ||
| """Tests if error is raised when linter is executed over directory not using --recursive=y""" |
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
for more information, see https://pre-commit.ci
What does it mean?
Thank you. That is a honour for me. I am interested but I cannot guarantee how much time I will allocate to pylint/astroid. I am working based what is interesting in given moment. So I cannot guarantee my availability long term. |
I cannot mail you at "matusvalo@users.no-reply.github.com" :)
There's no expectation of availability - even if you're the world expert in pylint's deprecation checkers (it's just very convenient if you shows up when there's a talk about something you know a lot about or if you're able to hot fix a mess by yourself) 😉 |
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
* Ignore specified files/directories in recursive mode Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
|
@DanielNoord I think we used the 2.14 configuration when we use |
* Ignore specified files/directories in recursive mode Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
* Ignore specified files/directories in recursive mode Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Type of Changes
Description
This PR checks ignore configuration during directory discovery and ignores specified directories.
Closes #6471