Skip to content

Fix crash in no-member check for C extensions #6235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jacobtylerwalls wants to merge 6 commits into from
Closed

Fix crash in no-member check for C extensions #6235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee94d81
Fix crash in `c-extension-no-member` check
jacobtylerwalls Apr 8, 2022
3b45837
Update changelog
jacobtylerwalls Apr 8, 2022
c794ebe
Update ChangeLog
jacobtylerwalls Apr 8, 2022
2f2ab0e
Add #6221
jacobtylerwalls Apr 8, 2022
0b288ec
Update pylint/checkers/typecheck.py
Pierre-Sassoulas Apr 8, 2022
9d17471
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ Release date: TBA
attribute to itself without any prior assignment.

Closes #1555
Closes #6221

* The concept of checker priority has been removed.

Expand Down
1 change: 1 addition & 0 deletions doc/whatsnew/2.14.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,4 @@ Other Changes
attribute to itself without any prior assignment.

Closes #1555
Closes #6221
5 changes: 5 additions & 0 deletions pylint/checkers/typecheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,6 +1053,11 @@ def visit_attribute(self, node: nodes.Attribute) -> None:
missingattr.add((owner, name))
continue
else:
if isinstance(attr_nodes, nodes.NodeNG):
# If owner was a living object, attr_nodes might be a node itself
# Faster than retrieving the module object and testing _is_c_extension()
# https://github.com/PyCQA/pylint/pull/6235#issuecomment-1093098869
break # pragma: no cover
for attr_node in attr_nodes:
attr_parent = attr_node.parent
# Skip augmented assignments
Expand Down