Deprecate find_pylintrc

[DanielNoord]

• Add yourself to CONTRIBUTORS if you are a new contributor.
• Write a good description on what the PR does.

Type of Changes

	Type
✓	🔨 Refactoring

Description

I wonder if this is considered external. It is in the __all__ but there is no reason for anybody to use this, I think? We don't even use it as the logic for finding the configuration file has moved to find_default_config_files.

[coveralls]

Pull Request Test Coverage Report for Build 2065693093

• 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
• 8 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.05%) to 94.16%

---

Files with Coverage Reduction	New Missed Lines	%
pylint/config/find_default_config_files.py	8	46.3%

Totals
Change from base Build 2064262785:	-0.05%
Covered Lines:	15414
Relevant Lines:	16370

---

💛 - Coveralls

The coverage went down

[Pierre-Sassoulas]

The coverage decreased because there were tests to check that we could browse a python package to find the pylintrc in parent directory too.

I would be in favor of searching at the root of the project in pyproject.toml, setup.cfg, pylintrc and .pylintrc and only that. It's already a lot more than what flake8 is doing for example. Guess which project has less issues to handle ? 😄 I think it's the way pylint is used most of the time (or should be used). And we added the possibility to do pylint . recently.But it's definitely a breaking change and I also think it's contrary to the per-directory configuration that was a big project of @AWhetter.

This is related to #3769 where they were discussion about configuration.

[DanielNoord]

The coverage decreased because there were tests to check that we could browse a python package to find the pylintrc in parent directory too.

I would be in favor of searching at the root of the project in pyproject.toml, setup.cfg, pylintrc and .pylintrc and only that. It's already a lot more than what flake8 is doing for example. Guess which project has less issues to handle ? 😄 I think it's the way pylint is used most of the time (or should be used). And we added the possibility to do pylint . recently.But it's definitely a breaking change and I also think it's contrary to the per-directory configuration that was a big project of @AWhetter.

This is related to #3769 where they were discussion about configuration.

The issue is that these tests don't test that.. I removed these tests because the only asserts are on find_pylintrc which we don't use internally.
I have a refactor of find_default_config_files ready to go, so I would be more than happy to add similar tests for that function in a follow-up PR.

Edit: Let me rephrase, these tests test that behaviour indirectly. I would like to refactor the function and test directly rather than through find_pylintrc.

[Pierre-Sassoulas]

I think we should deprecate find_pylintrc first, before removing in 3.0, it's an API. We can add the new tests in this MR too.

[Pierre-Sassoulas]

Lgtm, thank you.