Refactor _is_type_checking_import of unused-import#5410
Merged
DanielNoord merged 2 commits intopylint-dev:mainfrom Nov 27, 2021
Merged
Refactor _is_type_checking_import of unused-import#5410DanielNoord merged 2 commits intopylint-dev:mainfrom
_is_type_checking_import of unused-import#5410DanielNoord merged 2 commits intopylint-dev:mainfrom
Conversation
DanielNoord
added
the
Maintenance
4 tasks
Pull Request Test Coverage Report for Build 1511355072
💛 - Coveralls |
cdce8p
reviewed
Nov 27, 2021
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
cdce8p
approved these changes
Nov 27, 2021
Member
cdce8p
left a comment
cdce8p
left a comment
There was a problem hiding this comment.
Looks good. Thanks @DanielNoord 🐬
Github is having some issue at the moment, so I think it's fine even if the CodeQL job fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
#5316 (comment) and adds a changelog for that PR.