Update documentation on writing tests for pylint#5366
Merged
Conversation
Pull Request Test Coverage Report for Build 1490882619
💛 - Coveralls |
Collaborator
Author
|
Should probably add |
Member
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Amazing 👍 I have some small remarks
Comment on lines
+109
to
+115
| For example, if the configuration should add a warning to the list of disabled messages the | ||
| `.json` file should include:: | ||
|
|
||
| "functional_append": { | ||
| "disable": [["a-message-to-be-added"],] | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| For example, if the configuration should add a warning to the list of disabled messages the | |
| `.json` file should include:: | |
| "functional_append": { | |
| "disable": [["a-message-to-be-added"],] | |
| } | |
| For example, if the configuration should add a warning to the list of disabled messages | |
| and you changed the configuration for ``job`` to 10 instead of the default 1 the | |
| `.json` file should include:: | |
| "functional_append": { | |
| "disable": [["a-message-to-be-added"],] | |
| } | |
| "jobs": 10, | |
Collaborator
Author
There was a problem hiding this comment.
👍
Can't commit this one as well..
Comment on lines
+42
to
+44
| python -m tox -e py36 -- -k test_functional | ||
| python -m tox -e py36 -- -k \*func\* | ||
| python -m tox --recreate -e py36 -- -k test_functional # With recreation of the environment |
Member
There was a problem hiding this comment.
Suggested change
| python -m tox -e py36 -- -k test_functional | |
| python -m tox -e py36 -- -k \*func\* | |
| python -m tox --recreate -e py36 -- -k test_functional # With recreation of the environment | |
| python -m tox -e py39 -- -k test_functional | |
| python -m tox -e py39 -- -k \*func\* | |
| python -m tox --recreate -e py39 -- -k test_functional # With recreation of the environment |
Also upgraded the version so we appear hype :)
Collaborator
Author
There was a problem hiding this comment.
Should we add those last 3 lines? The 5 lines after this basically cover pytest already.
Pierre-Sassoulas
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Thought I shouldn't ask for better documentation while not doing some of it myself. Nobody likes writing docs 😄
Based on my comment in #5365