Remove legacy null symbol handling #3054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we need this mechanism it's better to handle it everywhere.
Pierre-Sassoulas
force-pushed
the
remove-legacy-null-symbol-handling
branch
from
4bc1e06 to
1255673
Compare
Member
Author
|
@PCManticore this is the one you need to review to move forward :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove a mechanism that was handling symbol equal to None. It does not happens in the current tests and we want to have a 1-1 link between symbol and msgid anyway.
Type of Changes
Related Issue
Permit to make #2992 easier to review.