Enforce 1 1 mapping between msgid and symbol #3053
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will permit to improve performance with less check but more importantly simplify the message store a lot.
Member
Author
|
Those changes make more sense inside #2992. |
Pierre-Sassoulas
deleted the
enforce-1-1-mapping-between-msgid-and-symbol
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request enforce the 1-1 mapping between msgid and symbol by renaming the old symbol name to something else than the new name. It does not change anything for the user because the symbolic name still exists within the active message. This will be enforced in code later.
Type of Changes
Related Issue
Next in line in order to make #2992 easier to review.