Add unittests for MessageDefinition #3041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the standard of the Message class.
It was only used in tests never in code.
Pierre-Sassoulas
force-pushed
the
small-amelioration-in-pylint-message
branch
from
7044dad to
d53fc49
Compare
Pierre-Sassoulas
force-pushed
the
small-amelioration-in-pylint-message
branch
from
d53fc49 to
c629e08
Compare
2 similar comments
Pierre-Sassoulas
force-pushed
the
small-amelioration-in-pylint-message
branch
from
c629e08 to
66774ef
Compare
Pierre-Sassoulas
force-pushed
the
small-amelioration-in-pylint-message
branch
from
66774ef to
a07f989
Compare
Contributor
|
Great stuff @Pierre-Sassoulas ! Thank you for splitting that PR up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes some minor naming problem and add unit tests for MessageDefinition to achieve better coverage without functional test. Adding unit tests also permitted to realise that add_message was not used anywhere but in tests.
Type of Changes
Related Issue
Smaller merge request to make #2992 easier to review.