-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Easier debugging for functional tests #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier debugging for functional tests #3021
Conversation
83a2be0 to
004bae0
Compare
20efeca to
6447b37
Compare
Easier debugging of the tests.
Permit to place the functional tests wherever we want.
…nctional_tests.py Permit to navigate in the functional tests easier.
Or we get a "module does not exists".
6447b37 to
f4f34bd
Compare
|
@PCManticore #2036 is based on this one, this is not absolutely necessary for it to work, but I would appreciate to not have to rewrite the commit tree :) |
AWhetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has bugged me for a while. Seems like a good change to me!
AWhetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has bugged me for a while. Seems like a worthwhile change to me!
|
This is awesome! 😄 Thank you for tackling it @Pierre-Sassoulas Merged it manually to get rid of the conflicts. |
Description
This merge request permits to :
NoFileErroris launched.FunctionalTest:test_nameinstead of<functional test object hexhash>.Previously :
With this merge request :
tests/functionalby usingos.walkinstead ofos.listdir. There were hundreds of files all in the same directory and it was beginning to be hard to navigate. Now you can put any tests in any directory insidetests/functional.tests/functional/example_tests.py=>tests/functional/e/example_test.py. For functional test starting withtoomove them in atests/functional/toodirectory so developers are aware it's a possibility and there aren't any magic going on forcing you to use the one letter directory approach.Type of Changes