Fixes for linting of new style logging format. #2713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neykov
commented
Jan 29, 2019
| # special keywords - out of scope. | ||
| return | ||
| elif self._format_style == "new": | ||
| keys, num_args, manual_pos_arg = utils.parse_format_method_string( |
There was a problem hiding this comment.
The bug was that num_args was overwriting the one at line 287, so the number of arguments always matches when using implicit positional placeholders. And never matches when using named arguments.
The changes are just renaming variables + removing the short-circuit for no arguments case above.
PCManticore
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
This looks good to me! Can you fix the CI failures? It's currently failing due to formatting issues. You can follow the pre-commit recommendations from the documentation (or run black manually over those files): http://pylint.pycqa.org/en/latest/development_guide/contribute.html#repository
The number of arguments was not handled properly, leading to an always successful check. See new tests for specific cases this fixes.
|
@PCManticore this is good to go. |
|
Thanks a lot @neykov for this PR! |
Pierre-Sassoulas
added a commit
that referenced
this pull request
Mar 30, 2025
…ated too The original decision was taken in db8b3a4 during implementation with a different rational ("If no args were supplied, then all format strings are valid don't check any further.") and was not discussed again when the comment was updated in #2713. I think the new behavior make sense especially considering that the primer shows 4 false negative in home-assistant. Co-authored by: Alex Prabhat Bara <[email protected]>
Pierre-Sassoulas
added a commit
that referenced
this pull request
Mar 30, 2025
…ated too The original decision was taken in db8b3a4 during implementation with a different rational ("If no args were supplied, then all format strings are valid don't check any further.") and was not discussed again when the comment was updated in #2713. I think the new behavior make sense especially considering that the primer shows 4 false negative in home-assistant. Co-authored-by: Alex Prabhat Bara <[email protected]>
DanielNoord
pushed a commit
that referenced
this pull request
Mar 30, 2025
… at all (#10321) * [feat] Detect missing formatting args when the string is not interpolated too The original decision was taken in db8b3a4 during implementation with a different rational ("If no args were supplied, then all format strings are valid don't check any further.") and was not discussed again when the comment was updated in #2713. I think the new behavior make sense especially considering that the primer shows 4 false negative in home-assistant. Co-authored-by: Alex Prabhat Bara <[email protected]> * Fix required because logging are tested elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
The number of arguments was not handled properly, leading to an always successful check. See new tests for specific cases this fixes.
Type of Changes
Related Issue