Fix crash when a slice object is called
#10715
Open
+22
β2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 484e910 |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10715 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 176 176
Lines 19537 19537
=======================================
Hits 18750 18750
Misses 787 787
π New features to boost your workflow:
|
zenlyj
changed the title
prefer-typing-namedtuple and consider-math-not-float when a slice object is called.slice object is called
DanielNoord
approved these changes
Nov 3, 2025
Pierre-Sassoulas
added
Crash π₯
Pierre-Sassoulas
requested changes
Nov 3, 2025
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
I think it's okay to pre-filter, maybe we don't have to filter anymore after that ? (It's not the first crash that the fuzzing caught by using slice instead of functiondev/classdef, maybe we can anticipate other instances of that without waiting for "random luck"). Maybe by creating a safe_infer_call function ?
Comment on lines
116
to
117
| if not called: | ||
| return |
Member
There was a problem hiding this comment.
Suggested change
| if not called: | |
| return | |
| if not (called and isinstance(called, (nodes.FunctionDef, nodes.ClassDef))): | |
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Add a runtime type guard before accessing
qname()on inferred called function for bothprefer-typing-namedtupleandconsider-math-not-floatchecks.Closes #10708