-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is Faker a required dependency? #304
Comments
It's a dependency of astroid which is a dependency of pylint which is a dependency of pylint-django, and there was some kind of conflict - see #300 |
@carlio thinking about it though @OutOfFocus4 got some point. We should have probably pinned Faker only in CI and not force it onto users. @jpulec does installing newer Faker versions when running a released pylint-django cause the same crash we saw it the tests or no? That is is there any option to pin the version only in our own CI or not ? FTR I still haven't found time to investigate the underlying issue and chase this upstream. |
I have |
Using |
…dency of factoryboy (see also #300)
Fixed in v2.4.2, pushed to PyPI just now. |
@atodorov oops, thanks for releasing I had forgotten to do it :-) |
I installed the most recent version of
pylint-django
, and it installed thefaker
package. It doesn’t look likepylint-django
usesfaker
anywhere, so why was this dependency added?The text was updated successfully, but these errors were encountered: