Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This PR solves the issue #666.
The problem was that
astroidcould not infer the result of a call toappendfunction because this function, itself, calls theconcatenatefunction.This last function is inferred thanks to the
brain_numpy_core_multiarraymodule but only when the corresponding node is anastroid.Attribute(for examplenumpy.concatenate). It turns out that in the source of theappendfunction the node that realises the call toconcatenateis aastroid.Name. Thus the correction proposed here is to register theconcatenateinference tip function in order to apply it, also, toastroid.Name.Type of Changes
Related Issue
Closes #666