Prevent Const copy resulting in recursion #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCManticore
reviewed
Jun 22, 2018
Contributor
PCManticore
left a comment
PCManticore
left a comment
There was a problem hiding this comment.
Outside of the TODO removal, this looks good, thanks for tackling it!
|
|
||
| _astroid_bootstrapping() | ||
|
|
||
| # TODO : find a nicer way to handle this situation; |
Contributor
There was a problem hiding this comment.
Why was this TODO removed, is this the same bug?
Contributor
Author
There was a problem hiding this comment.
I thought so because of the semicolon referencing the recursion issue on the following line
astroid/node_classes.py
Outdated
| super(Const, self).__init__(lineno, col_offset, parent) | ||
|
|
||
| def __getattr__(self, name): | ||
| # This is needed becuase of Proxy's __getattr__ method. |
| Note: | ||
| Subclasses of this object will need a custom __getattr__ |
Contributor
There was a problem hiding this comment.
I wonder if we should try #205 to get rid of this Proxy implementation instead.
Calling object.__new__ on a Const node would result in infinite recursion Fix infinite recursion by explicitly raising AttributeError if __getattr__ is called for value See https://nedbatchelder.com/blog/201010/surprising_getattr_recursion.html for more details Close pylint-dev#565
Contributor
Author
|
Thanks for the review I'll take a look at #205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
object.__new__on a Const node would result in infinite recursionFix infinite recursion by explicitly raising AttributeError if
__getattr__is called for valueSee https://nedbatchelder.com/blog/201010/surprising_getattr_recursion.html
for more details
Close #565