[typing] Add sys check guard for typing.Self for python < 3.11 #2911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
previously approved these changes
Dec 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
+ Coverage 93.39% 93.42% +0.03%
==========================================
Files 92 92
Lines 11214 11223 +9
==========================================
+ Hits 10473 10485 +12
+ Misses 741 738 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Pierre-Sassoulas
force-pushed
the
typing-self-fix
branch
from
f94bf2f to
5e06b4e
Compare
DanielNoord
approved these changes
Dec 15, 2025
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
Pierre-Sassoulas
added a commit
that referenced
this pull request
Dec 15, 2025
…Self for python < 3.11 (#2912) [typing] Add sys check guard for typing.Self for python < 3.11 (#2911) Closes #2910 (cherry picked from commit 66df47f) Co-authored-by: Pierre Sassoulas <[email protected]>
|
Nice work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #2910