Add helper to iterate over all annotation nodes of Arguments #2860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In pylint there are two cases where we iterate over all annotations nodes of
Arguments
specifically to check if a specific node is one of them. Getting that check right is sometimes tricky as it's easy to forget something. Add a helper methodget_annotations()
similar to the existingget_children()
to return an iterator of all annotation nodes.https://github.com/pylint-dev/pylint/blob/91d57ad7ed5ca52efafa232dda996757ccf14352/pylint/checkers/utils.py#L1619-L1626
https://github.com/pylint-dev/pylint/blob/91d57ad7ed5ca52efafa232dda996757ccf14352/pylint/checkers/variables.py#L2213-L2220