Assign import nodes to module locals if used with global #2856
+62
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
=======================================
Coverage 93.33% 93.34%
=======================================
Files 92 92
Lines 11170 11176 +6
=======================================
+ Hits 10426 10432 +6
Misses 744 744
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cdce8p
force-pushed
the
import-with-globals
branch
from
b6f27d1 to
0abe4e6
Compare
|
Opened pylint-dev/pylint#10633 with the changes required for pylint after this PR is merged. |
DanielNoord
approved these changes
Oct 11, 2025
Pierre-Sassoulas
approved these changes
Oct 11, 2025
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
pylint-backport bot
pushed a commit
that referenced
this pull request
Oct 11, 2025
(cherry picked from commit 1afbca6)
cdce8p
added a commit
that referenced
this pull request
Oct 11, 2025
…used with global (#2857) Assign import nodes to module locals if used with global (#2856) (cherry picked from commit 1afbca6) Co-authored-by: Marc Mueller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to
AssignNamenodes,ImportandImportFromnodes should add the name to the module locals if used withglobal.This does resolve the
no-name-in-moduleerror seen forconcurrent.futures.ProcessPoolExecutorin Python 3.14.pylint-dev/pylint#10632.