Skip to content

Conversation

@Pierre-Sassoulas
Copy link
Member

No description provided.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0a6 milestone Jul 4, 2023
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge the last two PRs on the milestone, they're both unreleased bug fixes and we really need at least the crash fix.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #2236 (cbf868c) into main (ec57e49) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2236   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files          94       94           
  Lines       10930    10930           
=======================================
  Hits        10146    10146           
  Misses        784      784           
Flag Coverage Δ
linux 92.58% <100.00%> (ø)
pypy 90.94% <100.00%> (ø)
windows 92.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/__pkginfo__.py 100.00% <100.00%> (ø)

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Everything will be correct when these are rebased, yeah?

@jacobtylerwalls
Copy link
Member

Btw, I think Marc was hoping that an entire astroid alpha would be devoted to just #1867, so that's why I created a new milestones for that PR only. There's some merge conflicts after the inference module was removed; I should be able to push some changes to his branch and review it.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 71f81ee into main Jul 4, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the release-branch-3.0.0a6 branch July 4, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants