Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer members of Enums as instances of the Enum they belong to #1598

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Closes #744

Also partially refs #142.

We need some way to store attributes that are specific to an individual instance. I'm not sure if this is the best way so I'm open to feedback!

Type of Changes

Type
🐛 Bug fix
✨ New feature

@DanielNoord DanielNoord added Enhancement ✨ Improvement to a component Bug 🪳 labels Jun 6, 2022
@coveralls
Copy link

coveralls commented Jun 6, 2022

Pull Request Test Coverage Report for Build 2624305299

  • 38 of 38 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 92.124%

Totals Coverage Status
Change from base Build 2624303150: -0.005%
Covered Lines: 9439
Relevant Lines: 10246

💛 - Coveralls

@DanielNoord
Copy link
Collaborator Author

Marking as draft as there seem to be changes to this in 3.12 and possibly in 3.11:
python/cpython#93910

Perhaps we should retain old behaviour.

@DanielNoord DanielNoord marked this pull request as draft June 24, 2022 13:09
@DanielNoord DanielNoord marked this pull request as ready for review July 5, 2022 13:57
@DanielNoord DanielNoord marked this pull request as draft July 5, 2022 13:59
@DanielNoord DanielNoord added the Needs review 🔍 Needs to be reviewed by one or multiple more persons label Jul 6, 2022
@DanielNoord
Copy link
Collaborator Author

DanielNoord commented Jul 6, 2022

A decision was made to revert the change in:
python/cpython#93910

So, this is still valid for 3.11.

It's blocked by #1689 which is a bug fix that is necessary for the change here but I think this can already be reviewed.

@DanielNoord DanielNoord marked this pull request as ready for review July 6, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪳 Enhancement ✨ Improvement to a component Needs review 🔍 Needs to be reviewed by one or multiple more persons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type of enum value being incorrectly inferred
2 participants