Refactor field inference to _get_namedtuple_fields#1413
Merged
Conversation
DanielNoord
added
the
Maintenance
Pierre-Sassoulas
approved these changes
Feb 28, 2022
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
LGTM, but I'm way over my expertise in astroid level here 😄
Pull Request Test Coverage Report for Build 2595175199
💛 - Coveralls |
Collaborator
Author
|
@Pierre-Sassoulas Would you be okay with me merging this? It's just a refactor and the coverage drop is in |
Member
|
Sure let's merge this ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps
Description
Seeing as the other PR got merged quite fast, this is another attempt at extracting some code from #1306.
Again, no rush in reviewing.
Type of Changes
Related Issue